Reopen #363: Hydrostatic water column (FSI)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.88%. Comparing base (
31716f6) to head (37b13e6). Report is 38 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 86 86
Lines 5261 5261
=======================================
Hits 3624 3624
Misses 1637 1637
| Flag | Coverage Δ | |
|---|---|---|
| unit | 68.88% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@efaulhaber and @svchb do we need this example or should I close this PR?
I am fine with adding this example if the results are correct.
What is this again? Was it the hydrostatic water column resting on an elastic beam? IIRC, this was a toy example but pretty useless for validation, as the "analytical solution" used simplifications, so that the error is always quite large and it doesn't validate anything, really.
I'm against merging more examples that we don't really need. I prefer having useful validation examples from the literature only. Trixi.jl has too many examples, which makes it really hard for beginners.
Niklas and I as far as I know are not against having as many examples as possible. But of course we would need to restructure the examples folder structure + docs page at some point.
It's a validation example from Sun et al. (2019), as well as from O'Connor and Rogers (2021).
It's a validation example from Sun et al. (2019), as well as from O'Connor and Rogers (2021).
Please add this as a comment and a description of what that simulation does.
Superseeded by #724