Trixi.jl icon indicating copy to clipboard operation
Trixi.jl copied to clipboard

KA kernels for 3D P4est

Open benegee opened this issue 2 months ago • 2 comments

Add KernelAbstractions.jl kernels for basic rhs! functions for 3D P4estMesh implementation.

benegee avatar Sep 29 '25 12:09 benegee

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • [ ] The PR has a single goal that is clear from the PR title and/or description.
  • [ ] All code changes represent a single set of modifications that logically belong together.
  • [ ] No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • [ ] The code can be understood easily.
  • [ ] Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • [ ] There are no redundancies that can be removed by simple modularization/refactoring.
  • [ ] There are no leftover debug statements or commented code sections.
  • [ ] The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • [ ] New functions and types are documented with a docstring or top-level comment.
  • [ ] Relevant publications are referenced in docstrings (see example for formatting).
  • [ ] Inline comments are used to document longer or unusual code sections.
  • [ ] Comments describe intent ("why?") and not just functionality ("what?").
  • [ ] If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • [ ] The PR passes all tests.
  • [ ] New or modified lines of code are covered by tests.
  • [ ] New or modified tests run in less then 10 seconds.

Performance

  • [ ] There are no type instabilities or memory allocations in performance-critical parts.
  • [ ] If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • [ ] The correctness of the code was verified using appropriate tests.
  • [ ] If new equations/methods are added, a convergence test has been run and the results are posted in the PR.

Created with :heart: by the Trixi.jl community.

github-actions[bot] avatar Sep 29 '25 12:09 github-actions[bot]

Codecov Report

:x: Patch coverage is 77.49361% with 88 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 96.64%. Comparing base (f4bbcd9) to head (7c6ab4a). :warning: Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
src/solvers/dgsem_p4est/dg_3d.jl 74.60% 32 Missing :warning:
src/solvers/dgsem_structured/dg_3d.jl 44.12% 19 Missing :warning:
src/callbacks_step/stepsize_dg3d.jl 71.11% 13 Missing :warning:
src/callbacks_step/analysis_dg2d.jl 69.57% 7 Missing :warning:
src/callbacks_step/analysis_dg3d.jl 69.57% 7 Missing :warning:
src/solvers/dg.jl 60.00% 6 Missing :warning:
src/callbacks_step/save_solution.jl 66.67% 1 Missing :warning:
src/solvers/fdsbp_tree/fdsbp_1d.jl 83.33% 1 Missing :warning:
src/solvers/fdsbp_tree/fdsbp_2d.jl 85.71% 1 Missing :warning:
src/solvers/fdsbp_tree/fdsbp_3d.jl 85.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   96.80%   96.64%   -0.17%     
==========================================
  Files         528      528              
  Lines       42655    42775     +120     
==========================================
+ Hits        41292    41337      +45     
- Misses       1363     1438      +75     
Flag Coverage Δ
unittests 96.64% <77.49%> (-0.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 29 '25 14:09 codecov[bot]