Trixi.jl icon indicating copy to clipboard operation
Trixi.jl copied to clipboard

CompatHelper: bump compat for CairoMakie to 0.12 for package test, (keep existing compat)

Open github-actions[bot] opened this issue 1 year ago • 5 comments

This pull request changes the compat entry for the CairoMakie package from 0.10 to 0.10, 0.12 for package test. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

TODO

  • Update to Makie.jl v0.21
  • Remove older compatibility statements for Makie.jl etc. (if required)

github-actions[bot] avatar May 10 '24 00:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.16%. Comparing base (c221bca) to head (619575d). Report is 254 commits behind head on main.

Files with missing lines Patch % Lines
ext/TrixiMakieExt.jl 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   96.09%   91.16%   -4.94%     
==========================================
  Files         453      453              
  Lines       36481    36477       -4     
==========================================
- Hits        35055    33251    -1804     
- Misses       1426     3226    +1800     
Flag Coverage Δ
unittests 91.16% <0.00%> (-4.94%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 06:05 codecov[bot]

The CI failure looks real to me:

  type Camera3D has no field attributes
  Stacktrace:
    [1] getproperty(x::Makie.Camera3D, f::Symbol)
      @ Base ./Base.jl:37
    [2] iplot(pd::Trixi.PlotData2DTriangulated{StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, Matrix{Float64}, Matrix{Float64}, StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, StaticArraysCore.SVector{4, String}, Matrix{Int32}}; plot_mesh::Bool, show_axis::Bool, colormap::Symbol, variable_to_plot_in::Int64)
      @ TrixiMakieExt ~/work/Trixi.jl/Trixi.jl/ext/TrixiMakieExt.jl:265

see https://github.com/trixi-framework/Trixi.jl/actions/runs/9027943539/job/24807599498?pr=1936#step:7:3305

@asinghvi17 Since you created https://github.com/trixi-framework/Trixi.jl/pull/1937, do you have a suggestion how to fix this?

ranocha avatar May 10 '24 10:05 ranocha

Ah I didn't see that! Will look into it.

asinghvi17 avatar May 10 '24 11:05 asinghvi17

Thanks a lot!

ranocha avatar May 10 '24 18:05 ranocha

Do you know in which version the shading options were updated like this?

┌ Warning: `shading = false` is not valid. Use `Makie.automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/eziUH/src/lighting.jl:243

I would like to make sure that we don't get incompatible compatibility bounds in our Project.toml files.

ranocha avatar May 13 '24 15:05 ranocha

https://github.com/trixi-framework/Trixi.jl/pull/2194

ranocha avatar Jan 28 '25 12:01 ranocha