Trixi.jl icon indicating copy to clipboard operation
Trixi.jl copied to clipboard

CompatHelper: bump compat for CairoMakie to 0.11 for package test, (keep existing compat)

Open github-actions[bot] opened this issue 1 year ago • 3 comments

This pull request changes the compat entry for the CairoMakie package from 0.6, 0.7, 0.8, 0.9, 0.10 to 0.6, 0.7, 0.8, 0.9, 0.10, 0.11 for package test. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

github-actions[bot] avatar Feb 08 '24 00:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c5e743a) 89.67% compared to head (62cb68f) 84.31%. Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
- Coverage   89.67%   84.31%   -5.36%     
==========================================
  Files         458      458              
  Lines       36400    36396       -4     
==========================================
- Hits        32640    30686    -1954     
- Misses       3760     5710    +1950     
Flag Coverage Δ
unittests 84.31% <ø> (-5.36%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 19:02 codecov[bot]

Aha, there are some breaking changes that affect us:

Makie visualization tests for UnstructuredMesh2D: Error During Test at /home/runner/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:184
  Got exception outside of a @test
  type Camera3D has no field attributes
  Stacktrace:
    [1] getproperty(x::Makie.Camera3D, f::Symbol)
      @ Base ./Base.jl:37
    [2] iplot(pd::Trixi.PlotData2DTriangulated{StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, Matrix{Float64}, Matrix{Float64}, StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, StaticArraysCore.SVector{4, String}, Matrix{Int32}}; plot_mesh::Bool, show_axis::Bool, colormap::Symbol, variable_to_plot_in::Int64)
      @ TrixiMakieExt ~/work/Trixi.jl/Trixi.jl/ext/TrixiMakieExt.jl:265
...

See https://github.com/trixi-framework/Trixi.jl/actions/runs/7891195904/job/21534998549?pr=1841#step:7:3749

ranocha avatar Feb 14 '24 06:02 ranocha

@jlchan this looks like it could be code from you. Would you be able to take a look at this?

sloede avatar Feb 14 '24 08:02 sloede