Parabolic mortars for `P4estMesh`

[jlchan]

This PR should not be merged until https://github.com/trixi-framework/Trixi.jl/pull/1629 is merged.

This overlaps with the PR in https://github.com/trixi-framework/Trixi.jl/pull/1661 as well

[github-actions[bot]]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• [ ] The PR has a single goal that is clear from the PR title and/or description.
• [ ] All code changes represent a single set of modifications that logically belong together.
• [ ] No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• [ ] The code can be understood easily.
• [ ] Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• [ ] There are no redundancies that can be removed by simple modularization/refactoring.
• [ ] There are no leftover debug statements or commented code sections.
• [ ] The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• [ ] New functions and types are documented with a docstring or top-level comment.
• [ ] Relevant publications are referenced in docstrings (see example for formatting).
• [ ] Inline comments are used to document longer or unusual code sections.
• [ ] Comments describe intent ("why?") and not just functionality ("what?").
• [ ] If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

• [ ] The PR passes all tests.
• [ ] New or modified lines of code are covered by tests.
• [ ] New or modified tests run in less then 10 seconds.

Performance

• [ ] There are no type instabilities or memory allocations in performance-critical parts.
• [ ] If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• [ ] The correctness of the code was verified using appropriate tests.
• [ ] If new equations/methods are added, a convergence test has been run and the results are posted in the PR.

Created with :heart: by the Trixi.jl community.

[codecov[bot]]

Codecov Report

Attention: 179 lines in your changes are missing coverage. Please review.

Comparison is base (7fd4503) 65.05% compared to head (7e1dc7d) 95.04%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1662       +/-   ##
===========================================
+ Coverage   65.05%   95.04%   +29.99%     
===========================================
  Files         419      427        +8     
  Lines       34118    34448      +330     
===========================================
+ Hits        22194    32740    +10546     
+ Misses      11924     1708    -10216     

Flag	Coverage Δ
unittests	95.04% <47.66%> (+29.99%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ree_2d_dgsem/elixir_navierstokes_shearlayer_amr.jl	100.00% <100.00%> (ø)
...es/tree_3d_dgsem/elixir_advection_diffusion_amr.jl	100.00% <100.00%> (ø)
...3d_dgsem/elixir_advection_diffusion_nonperiodic.jl	100.00% <100.00%> (ø)
src/Trixi.jl	43.48% <ø> (ø)
src/callbacks_step/amr_dg1d.jl	97.32% <100.00%> (+97.32%)	:arrow_up:
src/callbacks_step/analysis_dg2d.jl	100.00% <100.00%> (+4.07%)	:arrow_up:
src/callbacks_step/analysis_dg3d.jl	100.00% <100.00%> (+5.13%)	:arrow_up:
src/equations/compressible_euler_1d.jl	97.38% <100.00%> (+60.93%)	:arrow_up:
src/equations/compressible_euler_2d.jl	99.13% <100.00%> (+3.80%)	:arrow_up:
src/equations/compressible_euler_3d.jl	88.45% <100.00%> (-7.31%)	:arrow_down:
... and 19 more

... and 233 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[DanielDoehring]

Thanks a lot for tackling this @jlchan @apey236 ! I left some suggestions where I spotted some debugging left-overs from my attempts.

[DanielDoehring]

@jlchan How bad are the merge conflicts? Does it make sense to stay with this or start from main again?

[DanielDoehring]

A reduced version of this PR is https://github.com/trixi-framework/Trixi.jl/pull/1691 which is forked from this to maintain commits from @jlchan and @apey236 .

[jlchan]

@jlchan How bad are the merge conflicts? Does it make sense to stay with this or start from main again?

I don't think they're bad. Since your PR supercedes ours, we should mostly just be using your commits.

Thanks for making the second PR. I'll take a look hopefully tomorrow.

[DanielDoehring]

Thanks for making the second PR. I'll take a look hopefully tomorrow.

Sure, reason for this was that this PR contains some stuff that we disregarded when doing TreeMesh PR.

[DanielDoehring]

With https://github.com/trixi-framework/Trixi.jl/pull/1691 being merged, this should be reduced to only adding the 3D part.

[jlchan]

@apey236 would you mind making a separate PR for your 3D parabolic mortar implementation? We can then close this PR

[apey236]

@apey236 would you mind making a separate PR for your 3D parabolic mortar implementation? We can then close this PR

@jlchan Sure I will.