Trixi.jl icon indicating copy to clipboard operation
Trixi.jl copied to clipboard

Prep `DGMulti` for non-conservative shock capturing

Open jlchan opened this issue 1 year ago • 3 comments

Should also improve efficiency and extend non-conservative terms to curved meshes.

https://github.com/trixi-framework/Trixi.jl/pull/1478 should be merged first to reduce the size of this PR.

jlchan avatar May 16 '23 22:05 jlchan

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (c3c0986) 89.67% compared to head (aa0a995) 86.59%. Report is 1 commits behind head on main.

Files Patch % Lines
src/solvers/dgmulti/flux_differencing.jl 0.00% 22 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
- Coverage   89.67%   86.59%   -3.08%     
==========================================
  Files         458      458              
  Lines       36400    36374      -26     
==========================================
- Hits        32640    31496    -1144     
- Misses       3760     4878    +1118     
Flag Coverage Δ
unittests 86.59% <0.00%> (-3.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 17 '23 00:05 codecov[bot]

Shall this be merged before the next breaking release?

ranocha avatar Feb 21 '24 10:02 ranocha

I probably won't have time to finish this before then, so I'm happy to wait until the next release.

jlchan avatar Feb 21 '24 14:02 jlchan