melody icon indicating copy to clipboard operation
melody copied to clipboard
verified publisher icon trivago

Bugfix: Unsubscribe from Redux store when component is unmounted

Open taueres opened this issue 7 years ago • 1 comments

connect was not correctly unsubscribing from the Redux store when componentWillUnmount was triggered in the childInstance.

I'm now forwarding the event componentWillUnmount to the WrapperComponent so that the cleanup is performed as expected.

taueres avatar Oct 31 '18 15:10 taueres

Is this PR still needed or can we close it? I saw there is another one with the exact same name https://github.com/trivago/melody/pull/73, which one of the two is the one we want to merge eventually?

abertelle avatar Mar 12 '19 13:03 abertelle