triton icon indicating copy to clipboard operation
triton copied to clipboard

Minimal changes to support llvm-15

Open bertmaher opened this issue 3 years ago • 4 comments

Inside Meta we're pushing to support llvm-15, so need some minor API changes.

The biggest difference since 11 is the move to opaque, untyped pointers; I've applied LLVMContext::setOpaquePointers(false) to work around this for now, and hopefully the move to MLIR will obviate this by the time LLVM 16 comes around.

bertmaher avatar Nov 18 '22 22:11 bertmaher

Is it ok to delay this until after the triton-mlir merge? triton-mlir uses LLVM-14 right now, and it still will at merge time. Then, one of the first thing that will be done after the merge will be to switch to LLVM ~HEAD

ptillet avatar Nov 19 '22 05:11 ptillet

That sounds fine; we’ve got an internal patch stack for changes like this so we aren’t blocked, I just expected it might be useful upstream too 🙂

bertmaher avatar Nov 19 '22 17:11 bertmaher

@ptillet , @Jokeren - to take advantage of this discussion - would there be any interest in a pull request with the changes required for opaque pointers? (if yes - I'm happy to send it (after some additional testing / cleanup)) (the changes should be fine for both LLVM-11 and LLVM-14 (to the best of my knowledge))

alexander-shaposhnikov avatar Nov 29 '22 07:11 alexander-shaposhnikov

Might be helpful if the patch can contribute to trition-mlir directly, from my perspective.

Jokeren avatar Nov 29 '22 21:11 Jokeren