triton icon indicating copy to clipboard operation
triton copied to clipboard

Support L2 cache hint

Open manman-ren opened this issue 11 months ago • 6 comments

This patch currently creates a cache policy for each load/store with eviction policy. It may be better to create cache policy globally for each function.

Fixes https://github.com/openai/triton/issues/3438

manman-ren avatar Mar 26 '24 18:03 manman-ren

Sorry, I have forgotten about the refactoring. Will convert to draft and do an internal review first.

manman-ren avatar Apr 19 '24 16:04 manman-ren

Thanks for working on this. LGTM.

I'm also curious about how this moves perf. Maybe kick off a Pytorch nightly perf run?

htyu avatar May 03 '24 21:05 htyu

What is the easiest way to kick off pytorch perf test? Is it changing the pytorch pin to this hash, then start some job from the diff? @htyu

manman-ren avatar May 07 '24 19:05 manman-ren

What is the easiest way to kick off pytorch perf test? Is it changing the pytorch pin to this hash, then start some job from the diff? @htyu

Yes. Once you update pytorch pin with this one, push it to a personal branch in pytorch repro and submit a perf run on a branch by using:

https://github.com/pytorch/pytorch/actions/workflows/inductor-perf-test-nightly.yml

Then see the result ~12 hours later in: https://hud.pytorch.org/benchmark/compilers

htyu avatar May 08 '24 21:05 htyu

how is the perf result?

alexanderwh avatar Sep 05 '24 07:09 alexanderwh

how is the perf result?

Sorry, still didn't get a chance to measure it on pytorch.

manman-ren avatar Sep 05 '24 21:09 manman-ren