triton icon indicating copy to clipboard operation
triton copied to clipboard

Published 20 hours ago • verified publisher icon triton-lang

Stronger checks on ScanOp and ReduceOp

Open lezcano opened this issue 1 year ago • 2 comments

Addresses the discussion at https://github.com/openai/triton/pull/3111#discussion_r1488366197

lezcano avatar Feb 13 '24 19:02 lezcano

Addressed the comments and rebased. Will add tests tomorrow. cc @ThomasRaoux @joker-eph in case you have more comments

lezcano avatar Feb 13 '24 19:02 lezcano

Lit test to check this? (We already have a file for this, I think it's called invalid.mlir.)

+1 this should go here: triton/test/Triton/invalid.mlir

ThomasRaoux avatar Feb 13 '24 19:02 ThomasRaoux

Added a few tests.

lezcano avatar Feb 16 '24 14:02 lezcano

Can you fix the failing lit tests?

ThomasRaoux avatar Feb 19 '24 17:02 ThomasRaoux

Fixed. There was a bit of a mix-up with RankedTensorTypes and ElementTypes. Now it should be fine.

lezcano avatar Feb 19 '24 18:02 lezcano