server icon indicating copy to clipboard operation
server copied to clipboard

build.py broken in r24.11

Open prm-james-hill opened this issue 11 months ago • 6 comments

Description

This works:

git clone [email protected]:triton-inference-server/server.git
git checkout r24.10
python3 build.py

But after doing git checkout r24.11 or git checkout r24.12 and rerunning build.py I get the following error:

[ 18%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/_c/tritonfrontend_pybind.cc.o
[ 18%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/common.cc.o
[ 20%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/classification.cc.o
[ 22%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o
In file included from /workspace/src/classification.cc:27:
/workspace/src/classification.h:31:10: fatal error: triton/core/tritonserver.h: No such file or directory
   31 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:104: python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/classification.cc.o] Error 1
gmake[5]: *** Waiting for unfinished jobs....
In file included from /workspace/src/shared_memory_manager.cc:27:
/workspace/src/shared_memory_manager.h:33:10: fatal error: triton/core/tritonserver.h: No such file or directory
   33 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:76: python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o] Error 1
In file included from /workspace/src/common.cc:27:
/workspace/src/common.h:37:10: fatal error: triton/core/tritonserver.h: No such file or directory
   37 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:90: python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/common.cc.o] Error 1
/workspace/src/python/tritonfrontend/_c/tritonfrontend_pybind.cc:40:10: fatal error: triton/core/tritonserver.h: No such file or directory
   40 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:118: python/tritonfrontend/CMakeFiles/py-bindings.dir/_c/tritonfrontend_pybind.cc.o] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:831: python/tritonfrontend/CMakeFiles/py-bindings.dir/all] Error 2
gmake[4]: *** Waiting for unfinished jobs....

Triton Information r24.11 is the first version I see this behavior in.

To Reproduce See above description. I also tried with various tag and backend options but it didn't impact it. (EDIT: After enabling 90% of options it appears to work. I don't know which option is providing this header or fixing the include, though.) I'm on Ubuntu 24.04.

Expected behavior Build script to finish without error.

prm-james-hill avatar Jan 15 '25 02:01 prm-james-hill

I have the same issue

rusmux avatar Jan 22 '25 22:01 rusmux

I also have the same issue

NiklasA1 avatar Jan 24 '25 23:01 NiklasA1

git clone -b v2.54.0 --single-branch https://github.com/triton-inference-server/server.git cd server ./build.py -v

also encountered this error. In file included from /workspace/src/shared_memory_manager.cc:27: /workspace/src/shared_memory_manager.h:33:10: fatal error: triton/core/tritonserver.h: No such file or directory 33 | #include "triton/core/tritonserver.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.

tanchcliff avatar Feb 06 '25 04:02 tanchcliff

I have the same issue on r24.12 too. Hi @mc-nv @KrishnanPrash PTAL, thanks!

fighterhit avatar Feb 10 '25 08:02 fighterhit

Created PR: https://github.com/triton-inference-server/server/pull/8000

mc-nv avatar Feb 10 '25 23:02 mc-nv

@mc-nv

With or without --no-container-build , build.py still showing the error

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -P CMakeFiles/triton-common-thread-pool.dir/cmake_clean_target.cmake

[ 19%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o

cd /tmp/tritonbuild/tritonserver/build/triton-server/python/tritonfrontend && /usr/bin/c++ -DTRITON_ENABLE_GPU=1 -DTRITON_MIN_COMPUTE_CAPABILITY=6.0 -Dpy_bindings_EXPORTS -I/tmp/tritonbuild/tritonserver/install/include -isystem /tmp/tritonbuild/tritonserver/build/triton-server/_deps/pybind11-src/include -isystem /usr/include/python3.12 -isystem /usr/local/cuda/targets/x86_64-linux/include -O3 -DNDEBUG -fPIC -fvisibility=hidden -flto -fno-fat-lto-objects -MD -MT python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o -MF CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o.d -o CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o -c /workspace/src/shared_memory_manager.cc

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/triton-common-thread-pool.dir/link.txt --verbose=1

/usr/bin/ar qc libtritonthreadpool.a "CMakeFiles/triton-common-thread-pool.dir/thread_pool.cc.o"

/usr/bin/ranlib libtritonthreadpool.a

gmake[5]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

In file included from /workspace/src/shared_memory_manager.cc:27:

/workspace/src/shared_memory_manager.h:33:10: fatal error: triton/core/tritonserver.h: No such file or directory

   33 | #include "triton/core/tritonserver.h"

      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

compilation terminated.

gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:76: python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o] Error 1

gmake[5]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

gmake[4]: *** [CMakeFiles/Makefile2:926: python/tritonfrontend/CMakeFiles/py-bindings.dir/all] Error 2

gmake[4]: *** Waiting for unfinished jobs....

[ 20%] Building CXX object _deps/repo-common-build/src/CMakeFiles/triton-common-async-work-queue.dir/thread_pool.cc.o

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/c++  -I/tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-src/src/../include -I/tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-src/src -O3 -DNDEBUG -fPIC -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -MD -MT _deps/repo-common-build/src/CMakeFiles/triton-common-async-work-queue.dir/thread_pool.cc.o -MF CMakeFiles/triton-common-async-work-queue.dir/thread_pool.cc.o.d -o CMakeFiles/triton-common-async-work-queue.dir/thread_pool.cc.o -c /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-src/src/thread_pool.cc

[ 20%] Built target triton-common-thread-pool

[ 22%] Linking CXX static library libtritoncommonlogging.a

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -P CMakeFiles/triton-common-logging.dir/cmake_clean_target.cmake

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/triton-common-logging.dir/link.txt --verbose=1

/usr/bin/ar qc libtritoncommonlogging.a "CMakeFiles/triton-common-logging.dir/logging.cc.o"

/usr/bin/ranlib libtritoncommonlogging.a

gmake[5]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

[ 22%] Built target triton-common-logging

[ 23%] Linking CXX static library libtritontableprinter.a

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -P CMakeFiles/triton-common-table-printer.dir/cmake_clean_target.cmake

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/triton-common-table-printer.dir/link.txt --verbose=1

/usr/bin/ar qc libtritontableprinter.a "CMakeFiles/triton-common-table-printer.dir/table_printer.cc.o"

/usr/bin/ranlib libtritontableprinter.a

gmake[5]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

[ 23%] Built target triton-common-table-printer

[ 25%] Linking CXX static library libtritonasyncworkqueue.a

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -P CMakeFiles/triton-common-async-work-queue.dir/cmake_clean_target.cmake

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-common-build/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/triton-common-async-work-queue.dir/link.txt --verbose=1

/usr/bin/ar qc libtritonasyncworkqueue.a "CMakeFiles/triton-common-async-work-queue.dir/async_work_queue.cc.o" "CMakeFiles/triton-common-async-work-queue.dir/error.cc.o" "CMakeFiles/triton-common-async-work-queue.dir/thread_pool.cc.o"

/usr/bin/ranlib libtritonasyncworkqueue.a

gmake[5]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

[ 25%] Built target triton-common-async-work-queue

[ 26%] Linking CUDA device code CMakeFiles/kernel_library_new.dir/cmake_device_link.o

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-backend-build && /usr/bin/cmake -E cmake_link_script CMakeFiles/kernel_library_new.dir/dlink.txt --verbose=1

/usr/local/cuda/bin/nvcc -forward-unknown-to-host-compiler -O3 -DNDEBUG "--generate-code=arch=compute_53,code=[compute_53,sm_53]" "--generate-code=arch=compute_60,code=[sm_60]" "--generate-code=arch=compute_62,code=[sm_62]" "--generate-code=arch=compute_70,code=[sm_70]" "--generate-code=arch=compute_72,code=[sm_72]" "--generate-code=arch=compute_75,code=[sm_75]" "--generate-code=arch=compute_80,code=[sm_80]" "--generate-code=arch=compute_86,code=[sm_86]" "--generate-code=arch=compute_89,code=[sm_89]" "--generate-code=arch=compute_90,code=[sm_90]" -Xcompiler=-fPIC -Wno-deprecated-gpu-targets -shared -dlink --options-file CMakeFiles/kernel_library_new.dir/deviceObjects1.rsp -o CMakeFiles/kernel_library_new.dir/cmake_device_link.o --options-file CMakeFiles/kernel_library_new.dir/deviceLinkLibs.rsp

[ 27%] Linking CUDA static library libkernel_library_new.a

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-backend-build && /usr/bin/cmake -P CMakeFiles/kernel_library_new.dir/cmake_clean_target.cmake

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/repo-backend-build && /usr/bin/cmake -E cmake_link_script CMakeFiles/kernel_library_new.dir/link.txt --verbose=1

/usr/bin/ar qc libkernel_library_new.a CMakeFiles/kernel_library_new.dir/src/kernel.cu.o

/usr/bin/ar q libkernel_library_new.a CMakeFiles/kernel_library_new.dir/cmake_device_link.o

/usr/bin/ranlib libkernel_library_new.a

gmake[5]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

[ 27%] Built target kernel_library_new

[ 29%] Linking CXX static library ../../../lib/libgtest.a

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/googletest-build/googletest && /usr/bin/cmake -P CMakeFiles/gtest.dir/cmake_clean_target.cmake

cd /tmp/tritonbuild/tritonserver/build/triton-server/_deps/googletest-build/googletest && /usr/bin/cmake -E cmake_link_script CMakeFiles/gtest.dir/link.txt --verbose=1

/usr/bin/ar qc ../../../lib/libgtest.a "CMakeFiles/gtest.dir/src/gtest-all.cc.o"

/usr/bin/ranlib ../../../lib/libgtest.a

gmake[5]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

[ 29%] Built target gtest

gmake[4]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

gmake[3]: *** [Makefile:136: all] Error 2

gmake[3]: Leaving directory '/tmp/tritonbuild/tritonserver/build/triton-server'

gmake[2]: *** [CMakeFiles/triton-server.dir/build.make:86: triton-server/src/triton-server-stamp/triton-server-build] Error 2

gmake[2]: Leaving directory '/tmp/tritonbuild/tritonserver/build'

gmake[1]: *** [CMakeFiles/Makefile2:192: CMakeFiles/triton-server.dir/all] Error 2

gmake[1]: Leaving directory '/tmp/tritonbuild/tritonserver/build'

gmake: *** [Makefile:136: all] Error 2



error: build failed

the compiler command line in the build log still shows it using the incorrect host path (-I/root/server/build/tritonserver/install/include) when compiling the Python binding files.

karan-singh61 avatar Apr 30 '25 09:04 karan-singh61