server icon indicating copy to clipboard operation
server copied to clipboard

Revert "Fixing StringTo uint32_t used only by tracing (#6883)"

Open rvroge opened this issue 1 year ago • 3 comments

We are running the server and core in a armv7 device. Build for platform linux/arm/v7 failed because the reverted commit was disabling the template for 32 unsigned int variables.

This reverts commit fbe03b34f7836198d367a5cd3519ead64b278a2d.

What does the PR do?

Checklist

  • [ ] I have read the Contribution guidelines and signed the Contributor License Agreement
  • [x] PR title reflects the change and is of format <commit_type>: <Title>
  • [x] Changes are described in the pull request.
  • [ ] Related issues are referenced.
  • [ ] Populated github labels field
  • [ ] Added test plan and verified test passes.
  • [ ] Verified that the PR passes existing CI.
  • [ ] I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • [ ] Verified copyright is correct on all changed files.
  • [ ] Added succinct git squash message before merging ref.
  • [ ] All template sections are filled out.
  • [ ] Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type box here and add the label to the github PR.

  • [ ] build
  • [ ] ci
  • [ ] docs
  • [ ] feat
  • [ ] fix
  • [ ] perf
  • [ ] refactor
  • [ ] revert
  • [ ] style
  • [ ] test

Related PRs:

https://github.com/triton-inference-server/core/pull/395

Where should the reviewer start?

Test plan:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

rvroge avatar Sep 04 '24 20:09 rvroge

Hi @rvroge, thanks for contributing the PR! CC'ing a couple folks who may have some more context @oandreeva-nv @nv-kmcgill53

rmccorm4 avatar Sep 10 '24 19:09 rmccorm4

Just to confirm, you are wanting to build triton without tracing but you need access to the std::stoul template for your use case? We would need to confirm on our end that this change doesn't break our build with tracing enabled before merging.

nv-kmcgill53 avatar Sep 10 '24 20:09 nv-kmcgill53

Just to confirm, you are wanting to build triton without tracing but you need access to the std::stoul template for your use case? We would need to confirm on our end that this change doesn't break our build with tracing enabled before merging.

That's correct, we do not want to enable tracing. However, the build in our platform attempts to use the template for uint32_t (we are building for a 32 bit architecture).

rvroge avatar Sep 11 '24 18:09 rvroge