server icon indicating copy to clipboard operation
server copied to clipboard

Virtual hosted-style URLs for S3

Open TsykunovDmitriy opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. Our company has switched to using virtual hosted-style for S3 and I can’t deploy Triton because I use this. Ex. tritonserver --model-repository=s3://https://<bucket-name>.<host>:<port>/path/to/model/repository, output log - error: creating server: Internal - Unable to create S3 filesystem client. Check account credentials. Exception: '' Message: 'No response body.'

Describe the solution you'd like Triton has support for path and virtual hosted styles.

Additional context https://aws.amazon.com/ru/blogs/storage/update-to-amazon-s3-path-deprecation-plan/

Nvidia triton container version - 23.10

TsykunovDmitriy avatar Feb 23 '24 14:02 TsykunovDmitriy

CC @kthui, I am unaware of this transition, do you know if we've adjusted Triton?

oandreeva-nv avatar Feb 24 '24 01:02 oandreeva-nv

Hi, regarding

s3://https://<bucket-name>.<host>:<port>/path/to/model/repository

I don't think Triton strictly follows the S3 path style. The path format on Triton is documented here.

In your case, I think the path should look something like this

s3://https://<host>:<port>/<bucket-name>/path/to/model/repository

Note: only <bucket-name>, <host> and <port> are moved around and nothing is added/removed

kthui avatar Feb 26 '24 23:02 kthui

I tried this but it doesn't work. I think it's related to this - https://github.com/triton-inference-server/core/blob/main/src/filesystem/implementations/s3.h#L328 Maybe it is possible to add --enable-virtual-style-endpoint flag to tritonserver cli?

TsykunovDmitriy avatar Feb 27 '24 08:02 TsykunovDmitriy

Thanks for pointing out this needs to be set manually on the S3 client. I've filed a ticket for us to expose the setting.

kthui avatar Feb 27 '24 18:02 kthui