server icon indicating copy to clipboard operation
server copied to clipboard

Fix inference command sample in README.md

Open jasoncwik opened this issue 1 year ago • 5 comments

The inference sample in README.md did not work for me and I noticed there was a missing line continuation in the command line.

jasoncwik avatar Feb 06 '24 23:02 jasoncwik

CLA emailed to [email protected]

jasoncwik avatar Feb 06 '24 23:02 jasoncwik

Tested and confirmed fix:

$ docker run -it --rm --net=host nvcr.io/nvidia/tritonserver:24.01-py3-sdk \
/workspace/install/bin/image_client -m densenet_onnx -c 3 -s INCEPTION /workspace/images/mug.jpg

=================================
== Triton Inference Server SDK ==
=================================

NVIDIA Release 24.01 (build 80100517)

Copyright (c) 2018-2023, NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

Various files include modifications (c) NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license

WARNING: The NVIDIA Driver was not detected.  GPU functionality will not be available.
   Use the NVIDIA Container Toolkit to start this container with GPU support; see
   https://docs.nvidia.com/datacenter/cloud-native/ .

Request 0, batch size 1
Image '/workspace/images/mug.jpg':
    15.349567 (504) = COFFEE MUG
    13.227467 (968) = CUP
    10.424895 (505) = COFFEEPOT

jasoncwik avatar Feb 06 '24 23:02 jasoncwik

Hey Jason, thanks for the contribution!

Similar to step 1, I believe those are intended to be 2 separate commands, not a single one. If you copy and paste them individually, the sample should work. The difference is whether or not you'll stay in the container interactively after the command finishes.

Are you seeing otherwise?

rmccorm4 avatar Feb 09 '24 20:02 rmccorm4

Got it. I guess it wasn't immediately clear to me that you wanted to launch the container and then paste the command inside the container. I had copied and pasted both lines and the 2nd line paste didn't work automatically for some reason. IMO unless you have a reason to keep the user in the container, it's a little cleaner to make it one line, but I'll defer to you.

Oh, I suppose if it's decided to make it one line you could remove the -it too...

jasoncwik avatar Feb 09 '24 21:02 jasoncwik

CLA is approved. @jasoncwik can you rebase as well?

jbkyang-nvi avatar Feb 12 '24 21:02 jbkyang-nvi