server icon indicating copy to clipboard operation
server copied to clipboard

fix dcgm installation in build.py

Open w169q169 opened this issue 2 years ago • 2 comments

Building server in container will cause the following error:

./build.py -v --enable-all

bug

In the Americas region, developer.download.nvidia.com simply downloads the file. developer.download.nvidia.com just download file image

In China and other regions, developer.download.nvidia.com will return a 302 redirect response. The curl command is unable to download the file with the -L option enabled. image

w169q169 avatar Jul 25 '23 09:07 w169q169

Hi @w169q169, thanks for the contribution? Have you filled out a CLA?

@nv-kmcgill53 @mc-nv could you sanity check it's OK to follow redirects here when you get a chance?

rmccorm4 avatar Feb 09 '24 20:02 rmccorm4

Looks like this is also a duplicate of #5935

rmccorm4 avatar Feb 09 '24 20:02 rmccorm4

I am hesitant to allow "follow redirects" being checked for security reasons. I need to follow up with our team before we can merge.

@nv-kmcgill53 I don't see any issue with follow redirect on build process. We are not responsible for security issues users may face during their own build, in our case we should be safe unless there is internal attack.

mc-nv avatar Mar 04 '24 17:03 mc-nv