server icon indicating copy to clipboard operation
server copied to clipboard

Expose tritonserver args in values.yaml

Open okyspace opened this issue 2 years ago • 10 comments

Current k8s_onprem chart has predefined args in deployment.yaml. We could change it from the yaml file though but would be cleaner to customise the args through values.yaml instead.

okyspace avatar Apr 02 '23 11:04 okyspace

Seems reasonable to me. CC @nealvaidya for comments

rmccorm4 avatar Apr 04 '23 16:04 rmccorm4

Looks good to me

nealvaidya avatar Apr 04 '23 17:04 nealvaidya

@rmccorm4 , Thanks for your reply.

  1. I have updated the naming based on your suggestion.
  2. I can work out an example. Can advise where to provide this example?
  3. I will follow up with the CLA.

Thanks.

okyspace avatar Apr 06 '23 07:04 okyspace

@rmccorm4, as requested, I have added the examples for sanity check. Any comments?


The examples show how you can set the customised serverArgs and verify that they are taking effect.

  1. Execute the command below to generate the helm template to check that the serverArgs is being set correctly.
    helm template --set serverArgs="{'--model-repository=s3://192.168.1.110:9000/triton-models', '--repository-poll-secs=8', '--model-control-mode=poll', '--grpc-use-ssl=false'}" triton -n triton .

You should see the generated deployment.yaml. The serverArgs are populated as array args in this example. image

  1. Run the container using the command. helm install --set serverArgs="{'--model-repository=s3://192.168.1.110:9000/triton-models', '--repository-poll-secs=8', '--model-control-mode=poll', '--grpc-use-ssl=false'}" triton -n triton .

Run kubectl describe pods -n triton. You should see the args in the description. image

Once the container is successfully running, run kubectl logs <container id> -n triton. You should see these outputs that indicates the args set for the triton server.

for e.g. model-repository, model-control-mode image

for e.g. repository-poll-secs. You can see from the logs that "Polling model repository" happens every 8 secs. image

okyspace avatar Apr 20 '23 14:04 okyspace

I have also emailed my signed CLA.

okyspace avatar Apr 20 '23 14:04 okyspace

Hi, is there anything that I need to follow up to close this PR?

okyspace avatar Apr 27 '23 00:04 okyspace

@rmccorm4 , is there something i missed out for this PR?

okyspace avatar Nov 15 '23 19:11 okyspace

@rmccorm4 Thanks for the reviews and suggestions.

okyspace avatar Feb 22 '24 14:02 okyspace

I have also emailed my signed CLA.

Hi @okyspace, can you either resend this email or clarify the name and company attached to it?

rmccorm4 avatar Feb 22 '24 18:02 rmccorm4

@rmccorm4 I have resend the CLA. Name: Ong Kai Yong Company: N/A. I am not submitting on behalf of a company.

okyspace avatar Feb 22 '24 23:02 okyspace

Thanks for your contribution and patience @okyspace !

rmccorm4 avatar Mar 04 '24 19:03 rmccorm4