core icon indicating copy to clipboard operation
core copied to clipboard

fix: Fix response iterator in Python In-Process API

Open Tabrizian opened this issue 1 year ago • 2 comments

What does the PR do?

The response iterator destroyed the request object after final response is received which lead to destruction of the queue and responses not being retrieved by the user.

Checklist

  • [x] PR title reflects the change and is of format <commit_type>: <Title>
  • [x] Changes are described in the pull request.
  • [x] Related issues are referenced.
  • [ ] Populated github labels field
  • [x] Added test plan and verified test passes.
  • [ ] Verified that the PR passes existing CI.
  • [x] Verified copyright is correct on all changed files.
  • [ ] Added succinct git squash message before merging ref.
  • [x] All template sections are filled out.
  • [ ] Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type box here and add the label to the github PR.

  • [ ] build
  • [ ] ci
  • [ ] docs
  • [ ] feat
  • [X] fix
  • [ ] perf
  • [ ] refactor
  • [ ] revert
  • [ ] style
  • [x] test

Related PRs:

N/A

Where should the reviewer start?

N/A

Test plan:

Updated L0_python_api.

  • CI Pipeline ID: 15804851

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

Tabrizian avatar Jun 13 '24 16:06 Tabrizian

What is being held in request object? Aren't the responses being stored in the iterator?

GuanLuo avatar Jun 17 '24 23:06 GuanLuo

@GuanLuo I think the response_iterator was relying on a queue inside the request object which might be the root cause for this issue.

Tabrizian avatar Jun 24 '24 19:06 Tabrizian