client icon indicating copy to clipboard operation
client copied to clipboard

refactor: Remove C shared memory shim. Refine shared memory utils behavior. Add unit test for shared memory

Open GuanLuo opened this issue 4 months ago • 3 comments

What does the PR do?

Add unit test to constraint the behavior of shared memory utilities

Checklist

  • [x] PR title reflects the change and is of format <commit_type>: <Title>
  • [x] Changes are described in the pull request.
  • [ ] Related issues are referenced.
  • [ ] Populated github labels field
  • [x] Added test plan and verified test passes.
  • [ ] Verified that the PR passes existing CI.
  • [ ] Verified copyright is correct on all changed files.
  • [ ] Added succinct git squash message before merging ref.
  • [ ] All template sections are filled out.
  • [ ] Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type box here and add the label to the github PR.

  • [ ] build
  • [ ] ci
  • [ ] docs
  • [ ] feat
  • [ ] fix
  • [ ] perf
  • [x] refactor
  • [ ] revert
  • [ ] style
  • [ ] test

Related PRs:

Where should the reviewer start?

test_shared_memory.py has inline comment on change in behavior

Test plan:

L0_python_client_unit_tests

  • CI Pipeline ID:

19586188

Caveats:

This PR is marked as draft to collect feedback on the test cases and API level changes, the PR will be updated with new implementation which uses Python's native shared memory support

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

GuanLuo avatar Oct 22 '24 00:10 GuanLuo