Also build source distribution for Python client

[janjagusch]

Closes https://github.com/triton-inference-server/server/issues/4661.

With this PR, we're adding source distribution builds to the build script, which is necessary to add the package to conda-forge. The build_wheel.py script now creates a tritonclient*.tar.gz file additional to the tritonclient*.whl. It would make sense to rename the build script, for example, to build_dist.py, but I wanted this change to be as small as possible.

I don't know what's your release process but I would really appreciate a new PyPI release with the source distribution included, so I can continue with bringing tritonclient to conda-forge. Thanks a lot for your help! 🙏

[rmccorm4]

CC @szalpal

[jbkyang-nvi]

looks like there's a conflict somehow. Can you run the common/tools/format.py on this one?

[janjagusch]

looks like there's a conflict somehow. Can you run the common/tools/format.py on this one?

@jbkyang-nvi, I couldn't find the format.py script you were referring to but resolved the conflict manually. Is this good to get merged now?

[matthewkotila]

@janjagusch https://github.com/triton-inference-server/common/blob/main/tools/format.py

[janjagusch]

@Tabrizian et al., is there anything I can help you with so we can get this merged? 🙏

[Tabrizian]

@janjagusch Sorry about the delay. I'm just running this change through CI to make sure there aren't any issues. After that, I'll merge the PR. Thank you for your contribution!

[janjagusch]

Looks like you can't specify sdist the way you have specified. I think You need a separate run to generate the sdist.

@Tabrizian, sorry for not getting back to your sooner!

I'm not sure I understand. With the changes in this PR you can run:

python build_wheel.py --dest-dir .

And then the source distribution is located at ./wheel/tritonclient-test.tar.gz.

[janjagusch]

@Tabrizian, could you also please let me know which Git commit the 2.25.0 release was built with. Then I can go ahead and put that version on Conda-Forge already.

[samhedin]

How is this progressing? It would be extremely useful to have it on conda-forge. Not having it on conda-forge is currently preventing me from using it.

[janjagusch]

How is this progressing? It would be extremely useful to have it on conda-forge. Not having it on conda-forge is currently preventing me from using it.

@Tabrizian, is there any way we can move this PR forward? Maybe I don't understand your release process well enough, but all I'd need is a source distribution (.tar.gz) on PyPI with your next release. 😇

[janjagusch]

How is this progressing? It would be extremely useful to have it on conda-forge. Not having it on conda-forge is currently preventing me from using it.

FYI, we've just merged https://github.com/conda-forge/staged-recipes/pull/20820, so the tritonclient package should be on CF in a few hours. We've split it into three packages: tritonclient, tritonclient-http, and tritonclient-grpc.

We used the wheel for the conda build, which is less than ideal. Having the source distribution available on PyPI would still be much appreciated, as this helps tremendously maintain the feedstock long-term. 🙏

[matthewkotila]

@Tabrizian what's the status of this PR?

[the-david-oy]

Thank you for this pull request! We have discussed it internally. We may move forward with Condo, but we would do so with an internal team responsible for packaging and distributing software. As a result, I'll close this PR.