Fixing ordering of GamePlayer in sidePanel

[RenXFlo]

Fixed ordering for EconomyPanels in game (tested on 3 maps TWW included)

[CLAassistant]

All committers have signed the CLA.

[RenXFlo]

@frigoref could you look at this pull request and give me feedback

[frigoref]

@RenXFlo Did you check whether the ordering is still fixed?

[RenXFlo]

@RenXFlo Did you check whether the ordering is still fixed?

@frigoref It is on my side aam I some anomaly ? Does it not work for you ?

[frigoref]

@RenXFlo Did you check whether the ordering is still fixed?

@frigoref It is on my side aam I some anomaly ? Does it not work for you ?

@RenXFlo No, but I haven't tested it. So I wanted to confirm that after the changes done it is still giving the result from the screenshot of your initial post in this thread. When you confirm this I would merge the PR.

[RenXFlo]

@frigoref Yes it still does work as shown in the image.

[WCSumpton]

Would there be any way of removing isHidden players from these side menus.

Thank you

Cheers...

[frigoref]

@WCSumpton I do not understand what you are aiming at. 'isHidden' seems to be a method name. What does it have to do with the side menu which is an UI element?

[WCSumpton]

"isHidden" is an optional setting for players and hides the player from in the player selection screen. Since this is talking about displaying players in the UI side panel. I was wondering if players marked "isHidden" could also be hidden from there.

Cheers...

[frigoref]

@WCSumpton The available XML option isHidden is documented under https://www.starlords3k.com/XOB.html as

Optional switch If true, does not show in player selection window.

Hence, it should not be used for a display property of a player in the table Politics.

@DanVanAtta Could you please review this PR as requested - meaning answering the question on file PlayerOrderComparator.java in section Files changed?