triplea-game
Added tooltips for settings buttons. Fixed naming inconsistency.
Notes to Reviewer
My first ever pull request!
Fixes Issue #12777 adding tooltips to clarify meaning. Also renamed engine preferences tab to maintain consistency with button name.
I would leave the code as it is. The tooltips are just reiterating the text and are not necessary from my perspective. The popping up of a tooltip is not user friendly when there is not much added value. Renaming "Settings" to something more specific would be good I think. How about "Engine Settings"?
How about "Engine Settings"?
"Program Settings" would feel better to me, but I'm not sure what is the difference between "program" and "engine" and which one is the better term.
I'll point out that the Windows folder where TripleA is installed is called "Programs", not "Engines".
Also, maybe it should be "Program's Settings" or "Engine's Settings", shouldn't it?
Or maybe "General Settings" would be better from a user's perspective (mainly to differentiate them from more specific settings like the zoom (which is a "Map Setting", that is applying to every game of the same map) or the "Game Options", which are the settings for the game).
In practice, TripleA has 3 levels of settings: 1- Those which apply to all games 2- Those which apply to the map only (so to every game of the map) 3- Those which apply to the game only
It would be good to make them consistent and clear, but at this point I would say that this matter deserves its own issue or even forum thread.
For the button change PR 12999 (Update SettingsWindow.java) has been merged. The tooltips are not adding any value and are "rejected" as change. Hence, there is nothing more at the moment in this PR to be merged.
@Cernelius, @kevinjin12 Please feel free to open an issue page here on GitHub or a forum thread in the TripleA Forum on the consistency of naming the different settings level.