triplea icon indicating copy to clipboard operation
triplea copied to clipboard

Making`./verify` fast (under 2 minutes)

Open DanVanAtta opened this issue 2 years ago • 2 comments

./verify is the full "check-everything" script. Repeated runs were getting somewhat fast, but I've been stuck recently with lots of resource usage and the script crashing after 5 minutes if there is much other usage on my system. It is getting hard to run the verification!

Having the full verification be a minute or two is profoundly better than 5 (best yet if we can get in the 30 second range). Recently the verify script was able to manage sub-2 minutes.

For this issue, I'm thinking we discuss ways to get the script faster, and spitball if it makes sense to create verify as its own dedicated job and fail it if it takes too long (to prevent regressions)

DanVanAtta avatar Jun 27 '22 02:06 DanVanAtta

Currently at:

BUILD SUCCESSFUL in 3m 19s

Plus some time more for the custom checks.

DanVanAtta avatar Jun 27 '22 02:06 DanVanAtta

I've been finding that this has been super common to verify infrastructure updates:

cd infrastructure/vagrant
vagrant up
cd ../
./run_ansible --env vagrant

I wonder if this should be part of ./verify, or if we there should be another script, eg: ./verify-deployment. Notably because it is slow and secondly we cannot run a vagrant VM on a github-actions-docker (AFAIK),

DanVanAtta avatar Jun 27 '22 03:06 DanVanAtta

Closing for now, issue not currently actionable and discussion is quiet.

DanVanAtta avatar Nov 07 '22 06:11 DanVanAtta