trino icon indicating copy to clipboard operation
trino copied to clipboard

Published 20 hours ago • verified publisher icon trinodb

Support setting column comment when creating table in JDBC based connector

Open ebyhr opened this issue 5 years ago • 4 comments

Currently, it's ignored silently. We need to consider some RDBMS doesn't support setting a column comment in CREATE TABLE (e.g. PostgreSQL).

https://github.com/prestosql/presto/blob/22717c61419c851b1c3814b60a3453b22d4a45ef/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java#L477

https://github.com/prestosql/presto/blob/22717c61419c851b1c3814b60a3453b22d4a45ef/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java#L500-L510

ebyhr avatar Sep 29 '20 01:09 ebyhr