trino icon indicating copy to clipboard operation
trino copied to clipboard

fix the data pull problem when use alluxio as fs.

Open awkwardd opened this issue 1 year ago • 2 comments

Description

When use alluxio as hive fs,cant get data from alluxio. I finaly found that the AlluxioIterator.java didn't generate correct file location as alluxio://192...../dir/filename but alluxio:///dir/filename, so I modify the code.It works for me.Fix the issue#23778

awkwardd avatar Oct 17 '24 07:10 awkwardd

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tanyajun. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Oct 17 '24 07:10 cla-bot[bot]

Could you add a test for this problem ?

raunaqmorarka avatar Oct 17 '24 18:10 raunaqmorarka

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tanyajun. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Oct 31 '24 02:10 cla-bot[bot]

@awkwardd you may also need to sign the CLA https://trino.io/development/process#contribution-process

JiamingMai avatar Oct 31 '24 02:10 JiamingMai

@awkwardd you may also need to sign the CLA https://trino.io/development/process#contribution-process

I have signed the cla file and snet it last night.

awkwardd avatar Nov 01 '24 02:11 awkwardd

@cla-bot check

ebyhr avatar Nov 03 '24 22:11 ebyhr

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tanyajun. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Nov 03 '24 22:11 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Nov 03 '24 22:11 cla-bot[bot]

@awkwardd Please take a look at https://github.com/trinodb/trino/pull/23815#issuecomment-2453593098

ebyhr avatar Nov 03 '24 22:11 ebyhr

This change looks good to me. @raunaqmorarka Could you help merge this PR?

Can we add a test here ? The existing tests didn't catch this right ?

raunaqmorarka avatar Nov 19 '24 11:11 raunaqmorarka

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

github-actions[bot] avatar Dec 10 '24 17:12 github-actions[bot]