trino
trino copied to clipboard
Improve determinism by preserving split order
Description
In this we improve query execution determinism by
preserving split order when scheduling
in pipeline execution mode.
This is essentially needed such that splits coming out of CacheSplitSource preserve the order
between coordinator and workers. This way we
prevent scheduling two splits with same
CacheSplitId to reuse cache within a query.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:
# Section
* Fix some things. ({issue}`issuenumber`)
Started benchmark workflow for this PR with test type = iceberg/sf10000_parquet_part.
Building Trino finished with status:
successBenchmark finished with status:failureStatus message:
Started benchmark workflow for this PR with test type = hive/sf1000_parquet_part.
Building Trino finished with status:
successBenchmark finished with status:successStatus message: No baseline found. Benchmark Comparison Report
CI issue: https://github.com/trinodb/trino/issues/18697#issue-1853098596
Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.
Building Trino finished with status:
successBenchmark finished with status:successStatus message: NO Regression found. Benchmark Comparison Report