trino icon indicating copy to clipboard operation
trino copied to clipboard

[draft] Skip unsupported type widening columns

Open SemionPar opened this issue 8 months ago • 1 comments

Description

A change from failing to skipping is for flexibility, because Databricks supports wider variety of type changes.

Draft todos:

  • [x] add case for nested types
  • [x] add case for partition columns
  • [ ] UnsupportedTypeException.type -> message?
  • [ ] Fix failures when all columns are unsupported or specifically selecting only unsupported columns
assertQueryFails("SELECT * FROM " + tableName, "(.*)SELECT \\* not allowed from relation that has no columns");
assertQueryFails("SELECT col FROM " + tableName, "(.*)Column 'col' cannot be resolved");

Additional context and related issues

https://github.com/trinodb/trino/pull/22142, fixes https://github.com/trinodb/trino/issues/22433

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

SemionPar avatar Jun 20 '24 16:06 SemionPar