trino icon indicating copy to clipboard operation
trino copied to clipboard

file system cache doc change

Open MehulBatra opened this issue 1 year ago • 25 comments

Description

File system cache document change on optional fields

Additional context and related issues

As a developer when we try to enable caching, we face errors for setting options and try to look through it via logs what went wrong, if we could specify proactively that would make things easier.

Release notes

(*) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

MehulBatra avatar May 28 '24 13:05 MehulBatra

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 28 '24 13:05 cla-bot[bot]

Also update commit message to follow https://cbea.ms/git-commit/

mosabua avatar May 28 '24 17:05 mosabua

I chatted with some other writers on the team - for now we do not want to use () or italics for the required and optional terms since it does not provide much additional benefit but introduces an inconsistency with all the other docs.

mosabua avatar May 28 '24 17:05 mosabua

I chatted with some other writers on the team - for now we do not want to use () or italics for the required and optional terms since it does not provide much additional benefit but introduces an inconsistency with all the other docs.

@mosabua I picked up the idea of () from referring to the Trino Kubernetes docs itself, I found it quite clear as it was explicitly marked optional and caught my attention. image

MehulBatra avatar May 28 '24 18:05 MehulBatra

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 28 '24 18:05 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 28 '24 18:05 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 28 '24 18:05 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 28 '24 18:05 cla-bot[bot]

I chatted with some other writers on the team - for now we do not want to use () or italics for the required and optional terms since it does not provide much additional benefit but introduces an inconsistency with all the other docs.

@mosabua I picked up the idea of () from referring to the Trino Kubernetes docs itself, I found it quite clear as it was explicitly marked optional and caught my attention. image

Hm .. interesting .. I am not sure but to keep it simple I would suggest not to do that for now .. we can revisit for the complete docs or maybe take it out in the k8s docs.

mosabua avatar May 28 '24 18:05 mosabua

Also please squash commits and update commit message and submit CLA.

mosabua avatar May 28 '24 18:05 mosabua

Also please squash commits and update commit message and submit CLA.

CLA I have already submitted via email, changing the commit message and squashing it!

MehulBatra avatar May 28 '24 18:05 MehulBatra

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 28 '24 19:05 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 28 '24 19:05 cla-bot[bot]

Please fix wrapping to 80 character columns while we wait for CLA processing

mosabua avatar May 28 '24 20:05 mosabua

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar May 29 '24 16:05 cla-bot[bot]

@mosabua @martint when can we expect the cla to be processed, thank you! Please do let me know if anything is missing from my end.

MehulBatra avatar Jun 03 '24 08:06 MehulBatra

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jun 24 '24 17:06 github-actions[bot]

@cla-bot check

mosabua avatar Jun 24 '24 17:06 mosabua

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Jun 24 '24 17:06 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jun 24 '24 17:06 cla-bot[bot]

I just recently fixed something else in this section so you will have to rebse @MehulBatra .. sorry. CLA processing will happen soon.

mosabua avatar Jun 24 '24 17:06 mosabua

@cla-bot check

mosabua avatar Jun 26 '24 21:06 mosabua

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Jun 26 '24 21:06 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jun 26 '24 21:06 cla-bot[bot]

@MehulBatra CLA was processed now, seems like your git or github config is not using the right email and CLA bot verification is not working, also please rebase and resolve conflict.

Once all is good please ping me and I will review again and merge.

mosabua avatar Jun 26 '24 21:06 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jul 18 '24 17:07 github-actions[bot]

I am still working on it to get CLA resolved

MehulBatra avatar Jul 19 '24 08:07 MehulBatra

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Aug 12 '24 17:08 github-actions[bot]

Please

mosabua avatar Aug 26 '24 22:08 mosabua

I think all concerns are already addressed .. if not please reopen this PR and rebase, or send a new PR.

mosabua avatar Aug 26 '24 22:08 mosabua