trino
trino copied to clipboard
trinodb
Add timeout for setup step
Description
Set a distinct timeout just for the setup phase. It should either finish in few minutes or fail, no need to wait 1 hour (a timeout for the jobs).
Additional context and related issues
I have seen at least twice this week that a test lane failed during setup. It failed while trying to recreate cache. Might be a network problem, no idea.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:
# Section
* Fix some things. ({issue}`issuenumber`)
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
Here's some data around the duration of these steps in the last 7 days:
- avg on master 00:00:01.083
- max on master 00:01:54.000
- avg on all branches 00:00:01.199
- max on all branches 00:04:55.000
All steps: query_result_5-3-24--19-39.csv
The query:
select
r.name as workflow_name
, s.name as step_name
, count(*) as num_records
, avg(s.completed_at - s.started_at) filter (where r.head_branch = 'master') as avg_step_duration_master
, max(s.completed_at - s.started_at) filter (where r.head_branch = 'master') as max_step_duration_master
, avg(s.completed_at - s.started_at) as avg_step_duration
, max(s.completed_at - s.started_at) as max_step_duration
from steps s
join runs r on (r.owner, r.repo, r.id) = (s.owner, s.repo, s.run_id)
where s.owner = 'trinodb' and s.repo = 'trino'
and r.owner = 'trinodb' and r.repo = 'trino'
and s.started_at > current_date - interval '7' day
group by 1, 2
order by 1, 2
;
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla