trino icon indicating copy to clipboard operation
trino copied to clipboard

Flaky TestMongoDynamicFiltering.testJoinDynamicFilteringBlockProbeSide

Open ebyhr opened this issue 9 months ago • 5 comments

Error:  io.trino.plugin.mongodb.TestMongoDynamicFiltering.testJoinDynamicFilteringBlockProbeSide -- Time elapsed: 0.802 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 

expected: [1]
 but was: [39]
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at io.trino.plugin.mongodb.TestMongoDynamicFiltering.assertDynamicFiltering(TestMongoDynamicFiltering.java:176)
	at io.trino.plugin.mongodb.TestMongoDynamicFiltering.testJoinDynamicFilteringBlockProbeSide(TestMongoDynamicFiltering.java:160)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.tryRemoveAndExec(ForkJoinPool.java:1534)
	at java.base/java.util.concurrent.ForkJoinPool.helpJoin(ForkJoinPool.java:2269)
	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:495)
	at java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:662)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1491)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:2073)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2035)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)

https://github.com/trinodb/trino/actions/runs/8837410508/job/24266264851

ebyhr avatar Apr 26 '24 08:04 ebyhr

I can't reproduce the error on my laptop. Is there any way to rerun the action?

ZhangJianAo avatar Apr 28 '24 12:04 ZhangJianAo

1/1000 failed on my laptop. Please try @RepeatedTest annotation.

ebyhr avatar Apr 28 '24 12:04 ebyhr

https://github.com/trinodb/trino/actions/runs/8901798338/job/24446485721

ebyhr avatar Apr 30 '24 23:04 ebyhr

https://github.com/trinodb/trino/actions/runs/9014196600/job/24766578298?pr=21883

ebyhr avatar May 09 '24 08:05 ebyhr

https://github.com/trinodb/trino/actions/runs/9122281185/job/25082870737

ebyhr avatar May 17 '24 03:05 ebyhr

https://github.com/trinodb/trino/actions/runs/9391580264/job/25864189378

ebyhr avatar Jun 05 '24 22:06 ebyhr

@ZhangJianAo Any updates?

ebyhr avatar Jun 05 '24 22:06 ebyhr

This test runs the following sql:

SELECT l.comment FROM  lineitem l, part p, orders o WHERE
    l.orderkey = o.orderkey
    AND o.comment = 'nstructions sleep furiously among '
    AND p.partkey = l.partkey
    AND p.comment = 'onic deposits'

Normally there should be two column filters in dynamic filter, one for partkey, another for orderkey.

Screen Shot 2024-06-06 at 19 00 12

But sometimes, there is only one column filter in the dynamic filter:

Screen Shot 2024-06-06 at 18 52 13

I have noticed the futuresLeft is 1 when there is only one column filter. I am digging to find out why.

ZhangJianAo avatar Jun 06 '24 12:06 ZhangJianAo

https://github.com/trinodb/trino/actions/runs/9463902574/job/26070913235?pr=22302

findepi avatar Jun 11 '24 11:06 findepi

https://github.com/trinodb/trino/actions/runs/10098255060/job/27924965516

ebyhr avatar Jul 26 '24 00:07 ebyhr

@ZhangJianAo Could you share the current status?

ebyhr avatar Jul 26 '24 00:07 ebyhr

@ZhangJianAo Reminder.

ebyhr avatar Aug 06 '24 00:08 ebyhr

Found issue, will create PR later

sopel39 avatar Aug 06 '24 10:08 sopel39