trino icon indicating copy to clipboard operation
trino copied to clipboard

Log a message if file system caching is disabled on coordinator

Open developer-x opened this issue 2 years ago • 4 comments

Description

If a connector does not support caching on a Coordinator, Trino instantiates Alluxio JMX statistics but quietly disables caching. As a result, it appears that caching is instantiated and is operating. Consequently, it's really confusing when caching doesn't work but there is no indication why.

This PR will issue a warning on startup to let the user know that caching has been disabled for the Coordinator.

Considering this is a trivial PR, I didn't create a ticket. But if that is appropriate, I will open an issue.

Additional context and related issues

N/A

Release notes

(x) This is just a logging message, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

developer-x avatar Apr 22 '24 23:04 developer-x

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Andrew Hall. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Apr 22 '24 23:04 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Andrew Hall. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Apr 23 '24 14:04 cla-bot[bot]

Please submit CLA if you haven't sent it.

ebyhr avatar Apr 24 '24 03:04 ebyhr

I sent it yesterday to @.***

developer-x avatar Apr 24 '24 03:04 developer-x