trino icon indicating copy to clipboard operation
trino copied to clipboard

Enable enum equality predicate pushdown for ClickHouse connector

Open sylph-eu opened this issue 10 months ago • 2 comments

Description

Partially addresses #7100 .

Enables equality predicate pushdown for enum types. It's similar to VARCHAR (from Trino's perspective), but is not that "general-purpose". Until ClickHouse fully supports collation (atm it's only implemented for ORDER BY clause) range predicates are not pushed down.

Additional context and related issues

Submitted https://github.com/ClickHouse/ClickHouse/issues/62701 for unexpected behaviour.

Next I'll be looking at Decimals, time types and aggregate functions.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. (X ) Release notes are required, with the following suggested text:

# Section
* Enable enum equality predicate pushdown. ({issue}`7100`)

sylph-eu avatar Apr 17 '24 08:04 sylph-eu

Rebased.

sylph-eu avatar Apr 22 '24 13:04 sylph-eu

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 14 '24 17:05 github-actions[bot]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jun 12 '24 17:06 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Jul 04 '24 17:07 github-actions[bot]

Feel free to reopen and rebase or start a new PR if you want to continue working on this PR @sylph-eu

mosabua avatar Jul 04 '24 17:07 mosabua