trino
trino copied to clipboard
Add more query, stage, task info in web ui for troubleshooting more conveniently
Description
- Add client info in the query lists of
Cluster Overview
- Add percentage of CPU, Scheduling, Block Time in
Query Details
,Live Plan
andStage Performance
- Add spilled data size, revokable memory in
Query Details
andStage Performance
- Add raw input data size skew in
Query Details
- Add input std dev and input avg in
Stage Performance
Additional context and related issues
The following shows some renderings:
Release notes
( ) This is not user-visible or is docs only, and no release notes are required. (x) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:
# Section
* Add more query, stage, task info in web ui for troubleshooting more conveniently. ({issue}`21534`)
Add percentage of CPU, Scheduling, Block Time in Query Details, Live Plan and Stage Performance Add raw input data size skew in Query Details Add input std dev and input avg in Stage Performance
- I would skip std dev and maybe instead display gist of pXX for input rows (see
io.trino.operator.OperatorContext#getOperatorMetrics
)
Add spilled data size, revokable memory in Query Details and Stage Performance
-
This doesn't display when it's zero, right?
-
Skip blocked % as @raunaqmorarka mentioned
@hackeryang is it ready for re-review?
@hackeryang is it ready for re-review?
Sorry not yet, i'm trying to fix this CICD error:
But i'm not so good at React JSX, and i didn't figure out a good way to calculate time percents without null or NaN parameters in parseDuration()
. Maybe need some advice~
But i'm not so good at React JSX
That's not my domain either unfortunately.
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.
Reopening since we still want these changes I assume.
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla
Let us know how you want to proceed @hackeryang .. we are interested to get these changes added from all I can tell.
Let us know how you want to proceed @hackeryang .. we are interested to get these changes added from all I can tell.
Yes we want to proceed, for now i found a co-author @Max-Cheng who is good at React UI coding, i'll wait him to accomplish the CLA signing then cooperate with him~
@Max-Cheng Please let our community know when you met some problem about CLA signing and separating commits, and please cc the advice above by our reviewers~
Each time you push new commits, remember to rebase our local branch on the latest master branch, otherwise some irrelevant UTs will fail.
And please remember to execute npm install
to compile .jsx files into .js files if you have some changes about .jsx
: https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#building-the-web-ui
Let us know how you want to proceed @hackeryang .. we are interested to get these changes added from all I can tell.
Yes we want to proceed, for now i found a co-author @Max-Cheng who is good at React UI coding, i'll wait him to accomplish the CLA signing then cooperate with him~
@Max-Cheng Please let our community know when you met some problem about CLA signing and separating commits, and please cc the advice above by our reviewers~
Each time you push new commits, remember to rebase our local branch on the latest master branch, otherwise some irrelevant UTs will fail.
And please remember to execute
npm install
to compile .jsx files into .js files if you have some changes about.jsx
: https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#building-the-web-ui
Hello Community. New here.
Finished CLS sign last week, but using the wrong format. I've already sent another email to Martin (I knew that CLA works like batch, not stream ; ) ) So that I can look at this MR later.
I'm happy to help @hackeryang to develop this feature. I'll be back later to finish rebase and answer other reviewers.
Excellent news @hackeryang and @Max-Cheng
@cla-bot check
The cla-bot has been summoned, and re-checked this pull request!
Sorry for late with this pull request(Last week on vacation). I'm already finish the
- Skip blocked % as raunaqmorarka mentioned
- This doesn't display when it's zero
- show physicalInputSize for source stage But @hackeryang branch so late compare with upstream master. We will sync two fork repository after than update here.
@hackeryang please rebase
I think @wendigo will look at this soon.