trino icon indicating copy to clipboard operation
trino copied to clipboard

Avoid populating _schema if the collection is empty in MongoDB connector

Open build2create opened this issue 11 months ago • 8 comments

Description

This PR is to fix the [issue][1]. Whenever a empty collection was created an entry was populated in default collection _schema. Further upon populating the collection with documents the fields in _schema remained empty. So a workaround there is a check introduced to avoid populating _schema if collection is empty.

Fixes #20972

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

build2create avatar Mar 25 '24 13:03 build2create

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mithilesh Wachasunder. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Mar 25 '24 13:03 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mithilesh Wachasunder. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Apr 01 '24 06:04 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mithilesh Wachasunder. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Apr 01 '24 06:04 cla-bot[bot]

@cla-bot check

ebyhr avatar Apr 04 '24 00:04 ebyhr

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 04 '24 00:04 cla-bot[bot]

👋 @build2create - are you still interested in progressing this PR? If yes, could you address the comments from @ebyhr and fix any build failures?

mosabua avatar May 10 '24 17:05 mosabua

are you still interested in progressing this PR? If yes, could you address the comments from @ebyhr and fix any build failures?

Yes sorry its been a while will resume on this. Based on the offline chat with @ebyhr seems like a different behaviour with Mongo Compass and Java Client so the test results are different.

build2create avatar Jun 10 '24 18:06 build2create

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jul 09 '24 17:07 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Jul 30 '24 17:07 github-actions[bot]

I think @build2create and @ebyhr are going to continue here .. even if slowly. So I am adding the stale-ignore label.

mosabua avatar Jul 31 '24 17:07 mosabua

@cla-bot check

ebyhr avatar Oct 02 '24 23:10 ebyhr

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Oct 02 '24 23:10 cla-bot[bot]