trino icon indicating copy to clipboard operation
trino copied to clipboard

Support for extended boolean literal for LazySimpleSerde

Open guptashailesh92 opened this issue 11 months ago • 5 comments

Description

Hive supports hive.lazysimple.extended_boolean_literal for LazySimpleSerde.

LazySimpleSerde uses this property to determine if it treats 'T', 't', 'F', 'f', '1', and '0' as extended, legal boolean literal, in addition to 'TRUE' and 'FALSE'. The default is false, which means only 'TRUE' and 'FALSE' are treated as legal boolean literal.

Adding the same here.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

guptashailesh92 avatar Mar 19 '24 06:03 guptashailesh92

Can we refer the code link from Apache Hive as a part of commit message and PR description so that we could know where to look in the future.

Praveen2112 avatar Mar 19 '24 06:03 Praveen2112

@Praveen2112 PTAL

wendigo avatar Mar 20 '24 09:03 wendigo

Sure @wendigo I'm looking for PTs which ensure the behavior

Praveen2112 avatar Mar 20 '24 09:03 Praveen2112

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Apr 10 '24 17:04 github-actions[bot]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Jun 03 '24 17:06 github-actions[bot]

I reopened @Praveen2112 @wendigo since this still seems a valid improvement. Do you need any further help besides time to review?

mosabua avatar Jun 03 '24 17:06 mosabua