trino icon indicating copy to clipboard operation
trino copied to clipboard

Published 20 hours ago • verified publisher icon trinodb

Add retry and jmx metrics while generating Thrift's delegation token

Open osscm opened this issue 11 months ago • 5 comments

Description

Additional context and related issues

fixes : https://github.com/trinodb/trino/issues/20999

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`20999`)

osscm avatar Mar 09 '24 09:03 osscm

cc @electrum if you can please help with the review, thanks a lot!

osscm avatar Mar 09 '24 17:03 osscm

@electrum will cross check the pt failures.

osscm avatar Apr 09 '24 08:04 osscm

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

@osscm .. can you address the final remarks from @electrum .. I think this is ready to merge afterwards since he approved. Any concerns @findinpath ?

mosabua avatar May 13 '24 16:05 mosabua

Ack @manfred

On Mon, May 13, 2024 at 9:16 AM Manfred Moser @.***> wrote:

@osscm https://github.com/osscm .. can you address the final remarks from @electrum https://github.com/electrum .. I think this is ready to merge afterwards since he approved. Any concerns @findinpath https://github.com/findinpath ?

— Reply to this email directly, view it on GitHub https://github.com/trinodb/trino/pull/21000#issuecomment-2108129424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQ2PYWXQAF3TZKZTRUITK3ZCDRPLAVCNFSM6AAAAABEN6XRJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYGEZDSNBSGQ . You are receiving this because you were mentioned.Message ID: @.***>

osscm avatar May 15 '24 23:05 osscm

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jun 18 '24 17:06 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Jul 10 '24 17:07 github-actions[bot]

@electrum can you look .. seems like you approved already. Could you merge? I will see what the CI build does ...

mosabua avatar Jul 10 '24 18:07 mosabua

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mmalhotra. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 01 '24 06:09 cla-bot[bot]

Please squash commits

sopel39 avatar Sep 02 '24 12:09 sopel39

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mmalhotra. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 24 '24 15:09 cla-bot[bot]

lgtm % failure is related % please squash commits

updated, can we merge it now, please?

osscm avatar Oct 17 '24 15:10 osscm