trino icon indicating copy to clipboard operation
trino copied to clipboard

Published 20 hours ago • verified publisher icon trinodb

Hudi-connector: Proper exception handling and handle empty partition exception

Open ryadav-uptycs opened this issue 1 year ago • 23 comments

Description

select queries on hudi tables using hudi connectior are going into hang state incase of empty partition dir instead of throwing any error or skipping that partition Fixing below thing: (#19975)

  1. Fixing exception handling in hudi connector
  2. Fixing exception in case of empty partition

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

ryadav-uptycs avatar Feb 14 '24 15:02 ryadav-uptycs

@anusudarsan @homar could you please review the PR?

codope avatar Feb 14 '24 16:02 codope

LGTM. Please squash all commits

@anusudarsan Done

ryadav-uptycs avatar Feb 17 '24 11:02 ryadav-uptycs

@anusudarsan @homar could you please review the PR

ryadav-uptycs avatar Feb 20 '24 04:02 ryadav-uptycs

@anusudarsan @findinpath Please approve if changes are looking good . It is pending from long time

ryadav-uptycs avatar Mar 13 '24 12:03 ryadav-uptycs

@ryadav-uptycs Can you please update the PR desciption as per the template - https://github.com/trinodb/trino/blob/master/.github/pull_request_template.md?

codope avatar Mar 13 '24 13:03 codope

@electrum @findinpath Please take a look.

codope avatar Mar 13 '24 13:03 codope

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Apr 03 '24 17:04 github-actions[bot]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Apr 25 '24 17:04 github-actions[bot]

There are a bunch of approvals already .. what is preventing a merge here @findepi @anusudarsan .. can you maybe address any comments @ryadav-uptycs and then this can get in?

mosabua avatar Apr 25 '24 18:04 mosabua

There are a bunch of approvals already .. what is preventing a merge here @findepi @anusudarsan .. can you maybe address any comments @ryadav-uptycs and then this can get in?

@mosabua updated my comments

ryadav-uptycs avatar Apr 28 '24 07:04 ryadav-uptycs

@findepi I have done the suggested changes could please review it again and approve it please.

ryadav-uptycs avatar May 02 '24 04:05 ryadav-uptycs

@findinpath ptal

findepi avatar May 06 '24 13:05 findepi

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 29 '24 17:05 github-actions[bot]

Is this ready @ebyhr @findinpath @codope

mosabua avatar May 29 '24 17:05 mosabua

Also @yihua can you confirm this does not conflict with your work

mosabua avatar May 29 '24 17:05 mosabua

@ebyhr @mosabua resolved all review comments

ryadav-uptycs avatar Jun 02 '24 13:06 ryadav-uptycs

@ebyhr @mosabua Please approve this PR

ryadav-uptycs avatar Jun 11 '24 11:06 ryadav-uptycs

@ebyhr @mosabua Please approve this PR . it is pending from very long time

ryadav-uptycs avatar Jul 01 '24 14:07 ryadav-uptycs

Also @yihua can you confirm this does not conflict with your work

@mosabua No this should not conflict with the dehadooping work. Let's merge this PR. @anusudarsan Can you please rebase?

codope avatar Jul 01 '24 15:07 codope

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jul 24 '24 17:07 github-actions[bot]

@ebyhr @findepi is there anything still to be done apart from merging? I assume only the minor nits and the updated commit message. Correct?

mosabua avatar Jul 24 '24 17:07 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Aug 16 '24 17:08 github-actions[bot]