trino
trino copied to clipboard
trinodb
Iceberg: Add support for creating and dropping tables using Iceberg object store
Description
Currently, Trino is only able to write to and read from tables that use Iceberg's ObjectStorageLocationProvider, but is unable to create or drop tables using the location provider. This PR adds in session and table properties to use during table creation and removes an old check blocking Trino from dropping tables that use the object storage.
Additional context and related issues
This PR maintains compatibility with Spark by using the table properties write.object-storage.enabled and write.data.path, which had previously been set up to allow Trino to write to Iceberg tables using the ObjectStorageLocationProvider in https://github.com/trinodb/trino/pull/8573
Release notes
( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. (x) Release notes are required, with the following suggested text:
# Iceberg
* Add support for creating and dropping tables using Iceberg object store ({https://github.com/trinodb/trino/issues/8861}`8861`)
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.
I added the stale-ignore label so the PR stays open. Please rebase as a next step.
Hi @mosabua, pushed the rebase in. Looks like the failed check timed out but I'm not able to restart it. I'm also not sure what the process is for bumping Trino PRs, should I re-post in the Trino slack?