trino icon indicating copy to clipboard operation
trino copied to clipboard

Make SSL truststore and keystore configuration consistent across connectors

Open abusk opened this issue 2 years ago • 10 comments

Description

This PR creates a separate SSL config to make ssl/tls configuration consistent across connectors.

Additional context and related issues

Fixes #17103

Release notes

(x ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`17103`)

abusk avatar Jan 18 '24 11:01 abusk

Will update the ssl config for the rest of the connectors(Listed in the issue 17103) after this PR revision reviewed.

abusk avatar Jan 18 '24 11:01 abusk

Please remove unrelated commits.

ebyhr avatar Jan 22 '24 22:01 ebyhr

Made common ssl config for all the connectors mentioned in the issue description(17103), except for the Ldap and the Internal communication in the server.

Ldap has a legacy config ldap.ssl-trust-certificate which does not follow the pattern we are using in the config binding using prefix ldap.ssl.<suffix>

abusk avatar Jan 25 '24 11:01 abusk

@hashhar @ebyhr please review.

abusk avatar Jan 25 '24 11:01 abusk

@ebyhr please review again

abusk avatar Jan 28 '24 16:01 abusk

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 22 '24 17:02 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Mar 14 '24 17:03 github-actions[bot]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Apr 05 '24 17:04 github-actions[bot]

We should continue on this in my opinion. What is needed as next step @ebyhr or @wendigo ?

mosabua avatar Apr 05 '24 20:04 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Jun 03 '24 17:06 github-actions[bot]