trino
trino copied to clipboard
Add extra_properties to iceberg table properties
Description
This PR allows us to pass through additional properties to Iceberg when creating a table in Trino. The additional properties can be provided in the following format
extra_properties = MAP(ARRAY['extra.property.one', 'extra.property.two'], ARRAY['one', 'two'])
The extra properties will not be exposed in SHOW CREATE.
The purpose of this feature is to add properties that can be used by catalogs or other tools. For example, in Tabular, there is a property to optimize tables. For our use case, we want to create our tables with the optimizer.enabled value set to False, and we cannot achieve this without a way to handle arbitrary properties.
Additional context and related issues
Fixes #17427
Release notes
(x) Release notes are required, with the following suggested text:
# Iceberg
* Add support for `extra_properties` table properties. ({issue}`17427`)
regarding maven-checks failure :red_circle:
do the following before submitting the PR to ensure that the code you are changing follows the code conventions:
./mvnw clean install -P errorprone-compiler -DskipTests -nsu -pl :trino-iceberg
@findinpath @oneonestar @mosabua I made the requested changes!
@findinpath Done!
@mosabua ready for review!
I will work with maintainers for further review.
The f6fec7a commit includes changes to the Trino table properties for Iceberg naming, adding the suffix to maintain the pattern that already exists but was not being used for ORC_BLOOM_FILTER_FPP and ORC_BLOOM_FILTER_COLUMNS.
I believe that this PR is ready for review.
cc/ @findinpath @oneonestar @ebyhr
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
following this PR, any ETA on when this is going to be released?
@oneonestar Done!
Please rebase on master to resolve logical conflicts.
@ebyhr Done!
Can this go across the finish line with your help @alexjo2144 @ebyhr @findinpath and @cwsteinbach ?
Any updates on this one? We'd love to see this one in the next release
@zhmaeff Thank you for the review! I have fixed it.
@mosabua @ebyhr @findepi looks like this PR is ready for merge
Ping @ebyhr @findepi