trino
trino copied to clipboard
optimize MultilevelSplitQueue poll split by weight elimination
Description
MultilevelSplitQueue use getLevel0TargetTime() to get level0 target time and chose the worstRatio level, these steps is too complex, it was replaced by finding the level with the least scheduling time after weight elimination, much simpler and easier to understand. And i use precalculated level weight that only calculate once instead of calculate Math.pow(levelTimeMultiplier, level) every time offer split.
Additional context and related issues
Fix issue #19086
Release notes
(x) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: miaojiawei. This is most likely caused by a git client misconfiguration; please make sure to:
- check if your git client is configured with an email to sign commits
git config --list | grep email
- If not, set it up using
git config --global user.email [email protected]
- Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
@wendigo
@martint
cc @arhimondr @losipiuk
cc @sopel39 @lukasz-stec
hi, what should i do next?
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
👋 @pettyjamesm could you please have a look and review this?
@MiaoJiawei97 can you confirm that tests all pass for you and the CI failure is wrong?
CI failure is unrelated.
@sopel39 / @Dith3r can you take a look?
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
Thank you for the review and help @Dith3r and @hashhar
Can you address the comments @MiaoJiawei97 ?
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.
@martint PTAL
sorry for too late to rely
i will address these comments, thanks every one
how can i retry CI test ? or anybody help retry this, CI faile looks not related to my code.
You can just push an empty commit .. or rebase and push
@wendigo @mosabua @findepi @Dith3r finish all comments, PTAL