trino icon indicating copy to clipboard operation
trino copied to clipboard

optimize MultilevelSplitQueue poll split by weight elimination

Open MiaoJiawei97 opened this issue 1 year ago • 19 comments

Description

MultilevelSplitQueue use getLevel0TargetTime() to get level0 target time and chose the worstRatio level, these steps is too complex, it was replaced by finding the level with the least scheduling time after weight elimination, much simpler and easier to understand. And i use precalculated level weight that only calculate once instead of calculate Math.pow(levelTimeMultiplier, level) every time offer split.

Additional context and related issues

Fix issue #19086

Release notes

(x) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

MiaoJiawei97 avatar Sep 20 '23 11:09 MiaoJiawei97

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: miaojiawei. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 20 '23 11:09 cla-bot[bot]

@wendigo

MiaoJiawei97 avatar Sep 21 '23 02:09 MiaoJiawei97

@martint

wendigo avatar Sep 21 '23 05:09 wendigo

cc @arhimondr @losipiuk

findepi avatar Sep 22 '23 07:09 findepi

cc @sopel39 @lukasz-stec

findepi avatar Sep 22 '23 07:09 findepi

hi, what should i do next?

MiaoJiawei97 avatar Nov 06 '23 02:11 MiaoJiawei97

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jan 10 '24 17:01 github-actions[bot]

👋 @pettyjamesm could you please have a look and review this?

@MiaoJiawei97 can you confirm that tests all pass for you and the CI failure is wrong?

mosabua avatar Jan 11 '24 20:01 mosabua

CI failure is unrelated.

@sopel39 / @Dith3r can you take a look?

hashhar avatar Jan 12 '24 07:01 hashhar

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 02 '24 17:02 github-actions[bot]

Thank you for the review and help @Dith3r and @hashhar

Can you address the comments @MiaoJiawei97 ?

mosabua avatar Feb 02 '24 23:02 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 28 '24 17:02 github-actions[bot]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Mar 22 '24 17:03 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Apr 15 '24 17:04 github-actions[bot]

@martint PTAL

wendigo avatar Apr 30 '24 15:04 wendigo

sorry for too late to rely

i will address these comments, thanks every one

MiaoJiawei97 avatar Apr 30 '24 15:04 MiaoJiawei97

how can i retry CI test ? or anybody help retry this, CI faile looks not related to my code.

MiaoJiawei97 avatar May 15 '24 02:05 MiaoJiawei97

You can just push an empty commit .. or rebase and push

mosabua avatar May 15 '24 02:05 mosabua

@wendigo @mosabua @findepi @Dith3r finish all comments, PTAL

MiaoJiawei97 avatar May 15 '24 07:05 MiaoJiawei97