trino icon indicating copy to clipboard operation
trino copied to clipboard

Use Aircompressor in Avro library code

Open jklamer opened this issue 1 year ago • 13 comments

Description

Substitute Aircompressor code for Avro Codec Factories for snappy and Zstd.

Additional context and related issues

Allows us to further carve out Hadoop dependencies.

Release notes

(X ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

jklamer avatar Jul 28 '23 21:07 jklamer

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jan 11 '24 17:01 github-actions[bot]

:wave: @jklamer - this PR has become inactive. We hope you are still interested in working on it. Please let us know, and we can try to get reviewers to help with that.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.

mosabua avatar Jan 11 '24 22:01 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 02 '24 17:02 github-actions[bot]

Is this still in progress @jklamer .. also @electrum is this still something we need or was this removal already done separately?

mosabua avatar Feb 02 '24 23:02 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 28 '24 17:02 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Mar 21 '24 17:03 github-actions[bot]

I think this is still valid and in progress @jklamer @electrum

mosabua avatar Mar 21 '24 22:03 mosabua

I'll defer to @electrum. IIRC we wanted this change to avoid any sort of native code memory leaks for catalogConnector lifecycles. I know there is a concern that this Java version is noticeably slower.

jklamer avatar Mar 21 '24 22:03 jklamer

We still want to do this. Now that Java 22 has improved support for native code and fixed the GC locker issue, we plan to use native libraries in Aircompressor. Centralizing usage will let us upgrade and manage everything in one place.

electrum avatar Mar 21 '24 22:03 electrum

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Apr 15 '24 17:04 github-actions[bot]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

Added stale-ignore so that @jklamer and @electrum can proceed without the PR getting closed.

mosabua avatar May 29 '24 20:05 mosabua