trino icon indicating copy to clipboard operation
trino copied to clipboard

Add extra_properties to Delta Lake table properties

Open jkylling opened this issue 1 year ago • 9 comments

Description

Similar to https://github.com/trinodb/trino/pull/17172 this adds support for the extra_properties table property to Delta tables, such that additional table properties can be set on Delta tables.

The additional properties will not be exposed in SHOW CREATE.

It's a bit unclear how we should handle table properties which can be set by other features, and through extra_properties. Currently we take the simplest approach and allow setting properties both through Trino specific table properties, and through extra_properties. For instance, it's possible to set delta.enableChangeDataFeed both implicitly by setting change_data_feed_enabled, and explicitly by setting extra_properties = MAP(ARRAY['delta.enableChangeDataFeed'], ARRAY['true']).

Additional context and related issues

Fixes https://github.com/trinodb/trino/issues/17428

Release notes

( ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:

# Section
* Introduce `extra_properties` for adding arbitrary properties to Delta tables. ({issue}`17428`)

jkylling avatar May 22 '23 16:05 jkylling

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jan 15 '24 17:01 github-actions[bot]

@findinpath and @kasiafi could you work with @jkylling on next steps here .. assuming this is still in progress and a desired improvement.

mosabua avatar Jan 15 '24 19:01 mosabua

@jkylling was saying in a Slack discussion that he will address the PR comments as soon as he finds free time.

findinpath avatar Jan 15 '24 19:01 findinpath

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 07 '24 17:02 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Feb 29 '24 17:02 github-actions[bot]

I am reopening this since it is still in progress.

mosabua avatar Feb 29 '24 21:02 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Mar 26 '24 17:03 github-actions[bot]

Here is another one @jkylling that might have gone under your radar. Can you work with @findinpath to get this updated and ready.

mosabua avatar Mar 27 '24 22:03 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]