trino icon indicating copy to clipboard operation
trino copied to clipboard

Published 20 hours ago • verified publisher icon trinodb

Remove old expired kerberos tickets before relogging in

Open grantatspothero opened this issue 2 years ago • 11 comments

Description

This ensures old Kerberos tickets are removed before logging in again.

Approach is similar to this PR: https://github.com/trinodb/trino/pull/14373

but instead uses the LoginContext#logout method, which internally does similar logic to subject.getPrivateCredentials().clear()

Additional context and related issues

Stress test PR is here: https://github.com/trinodb/trino/pull/16018/files

Fixes: https://github.com/trinodb/trino/issues/14372 Fixes: https://github.com/trinodb/trino/issues/14441

Release notes

( ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:

# Section
Fix a bug in Kudu Kerberos ticket management. ({issue}`14372`)

grantatspothero avatar Feb 06 '23 23:02 grantatspothero

https://github.com/trinodb/trino/pull/14373 got merged, please rebase you may want to revert that change if you think the changes here made that one obsolete.

findepi avatar Feb 08 '23 10:02 findepi

@Praveen2112 @findepi @anusudarsan mind taking another look? Stress tests are green.

grantatspothero avatar Feb 10 '23 19:02 grantatspothero

@grantatspothero Can you please reword the commit Remove old expired kerberos tickets before relogging in and squash them.

Praveen2112 avatar Feb 16 '23 16:02 Praveen2112

Remove old expired kerberos tickets before relogging in

Was away on vacation 🌴, just fixed @Praveen2112

grantatspothero avatar Feb 22 '23 20:02 grantatspothero

@Praveen2112 can you take another look?

grantatspothero avatar Mar 03 '23 16:03 grantatspothero

@Praveen2112 fixed.

grantatspothero avatar Mar 03 '23 20:03 grantatspothero

@Praveen2112 some unrelated tests flaked, it looks like I do not have permission to rerun just the failed modules. Can you do that?

grantatspothero avatar Mar 06 '23 18:03 grantatspothero

CI hit: https://github.com/trinodb/trino/issues/16013

kokosing avatar Mar 08 '23 20:03 kokosing

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jan 17 '24 17:01 github-actions[bot]

:wave: @grantatspothero - this PR has become inactive. We hope you are still interested in working on it. Please let us know, and we can try to get reviewers to help with that.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.

mosabua avatar Jan 17 '24 19:01 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 12 '24 17:02 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Mar 05 '24 17:03 github-actions[bot]