trino icon indicating copy to clipboard operation
trino copied to clipboard

Make PushDownDereferenceThroughProject to not fire on non-identity source

Open weiatwork opened this issue 2 years ago • 8 comments

Description

Fixes #15659

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

weiatwork avatar Jan 11 '23 22:01 weiatwork

@martint I understand that #15680 will fix the issue from the perspective of not producing problematic symbol mappings. But I think the fix of this PR is still needed, as a local fix and safeguard to the specific rule

weiatwork avatar Jan 17 '23 18:01 weiatwork

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 20 '23 20:02 github-actions[bot]

@weiatwork looks like #15659 was fixed by #15680. I am closing this for now. Feel free to reopen if there is another issue that is left unresolved. Thank you!

bitsondatadev avatar Feb 21 '23 20:02 bitsondatadev

Hi Brian, thanks for the housekeeping. I understand that the original issue was fixed via a different PR. I was waiting on @martint to take a look if the change in this PR is still necessary, as a safeguard

weiatwork avatar Feb 21 '23 21:02 weiatwork

Ah cool, I'll reach out to him.

bitsondatadev avatar Feb 21 '23 21:02 bitsondatadev

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jan 17 '24 17:01 github-actions[bot]

@martint I think this can be closed now since you just merged a related PR. See links in the issue.

mosabua avatar Jan 17 '24 19:01 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 12 '24 17:02 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Mar 05 '24 17:03 github-actions[bot]