trino
trino copied to clipboard
[trino-parquet] Using ImmutableList for descriptor map key
Description
It is a bad practice to use mutable list(ArrayList as specified in ColumnIOFactory's ColumnIOCreatorVisitor's leaves) as a map key. Since one can modify the key's content.
Non-technical explanation
[trino-parquet] Using ImmutableList for descriptor map key
Release notes
(x) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:
# Section
* Fix some things. ({issue}`issuenumber`)
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yluan. This is most likely caused by a git client misconfiguration; please make sure to:
- check if your git client is configured with an email to sign commits
git config --list | grep email
- If not, set it up using
git config --global user.email [email protected]
- Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
Please update the commit message to Use ImmutableList for descriptor map key in parquet
Updated, thanks