trino icon indicating copy to clipboard operation
trino copied to clipboard

Add checkCanGrantExecuteFunctionPrivilege to ConnectorAccessControl

Open huberty89 opened this issue 2 years ago • 3 comments

Description

Follow-up to https://github.com/trinodb/trino/pull/13944 I will needed this to complete https://github.com/trinodb/trino/pull/13713

Release notes

( ) This is not user-visible and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:

# SPI
* Add `ConnectorAccessControl.checkCanGrantExecuteFunctionPrivilege` overload that needs to be implemented
  to allow views that use table functions. ({issue}`13944`)

huberty89 avatar Sep 19 '22 12:09 huberty89

I would like to add a test for that, but not sure where should I start.

huberty89 avatar Sep 19 '22 13:09 huberty89

lgtm % let's have a test

findepi avatar Sep 19 '22 20:09 findepi

You can use io.trino.tests.product.hive.TestSqlStandardAccessControlChecks for testing

kokosing avatar Sep 20 '22 19:09 kokosing

LGTM % test

kokosing avatar Sep 27 '22 20:09 kokosing

I rebased and add few tests in TestAccessControlManager

huberty89 avatar Oct 06 '22 12:10 huberty89

Maven checks are failiing

kokosing avatar Oct 06 '22 14:10 kokosing

@findepi @dain Would you like to take a look? I'm adding new method to SPI so I want to be sure if that's ok

huberty89 avatar Oct 07 '22 10:10 huberty89

Merged, thanks!

kokosing avatar Oct 08 '22 18:10 kokosing