trino
trino copied to clipboard
Add checkCanGrantExecuteFunctionPrivilege to ConnectorAccessControl
Description
Follow-up to https://github.com/trinodb/trino/pull/13944 I will needed this to complete https://github.com/trinodb/trino/pull/13713
Release notes
( ) This is not user-visible and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:
# SPI
* Add `ConnectorAccessControl.checkCanGrantExecuteFunctionPrivilege` overload that needs to be implemented
to allow views that use table functions. ({issue}`13944`)
I would like to add a test for that, but not sure where should I start.
lgtm % let's have a test
You can use io.trino.tests.product.hive.TestSqlStandardAccessControlChecks
for testing
LGTM % test
I rebased and add few tests in TestAccessControlManager
Maven checks are failiing
@findepi @dain Would you like to take a look? I'm adding new method to SPI so I want to be sure if that's ok
Merged, thanks!