trino icon indicating copy to clipboard operation
trino copied to clipboard

Add stage details and query plan details to QueryCompletedEvent

Open hiralbest opened this issue 3 years ago • 8 comments

Description

Non-technical explanation

Release notes

( ) This is not user-visible and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

hiralbest avatar Sep 15 '22 14:09 hiralbest

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Hiral Patel. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 15 '22 14:09 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Hiral Patel. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 15 '22 14:09 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Hiral Patel. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 15 '22 14:09 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Sep 15 '22 14:09 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Sep 15 '22 18:09 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Sep 16 '22 08:09 cla-bot[bot]

Submitted CLA to [email protected] with subject line as "Signed CLA for Trino - hiralbest Github User"

hiralbest avatar Sep 16 '22 08:09 hiralbest

Can you please describe the motivation for this change?

assaf2 avatar Sep 19 '22 13:09 assaf2

@cla-bot check

electrum avatar Sep 27 '22 17:09 electrum

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Sep 27 '22 17:09 cla-bot[bot]

Closing this PR since fields from newly added fields are already present in QueryMetadata. Thanks, everyone for reviewing and providing good pointers.

hiralbest avatar Oct 03 '22 09:10 hiralbest