trino icon indicating copy to clipboard operation
trino copied to clipboard

Published 20 hours ago • verified publisher icon trinodb

Upgrade minimum supported version to 21.8 in ClickHouse

Open ebyhr opened this issue 2 years ago • 2 comments

Description

Upgrade minimum supported version to 21.8 in ClickHouse Fixes #14112

Release notes

(x) Release notes are required, with the following suggested text:

# ClickHouse
* Upgrade minimum supported version to 21.8. ({issue}`14112`)

ebyhr avatar Sep 14 '22 09:09 ebyhr

I assume the motivation is to cleanup some code since we move from one EOL version to another EOL version?

IIUC the main purpose is to support escaping comment values, however unfortunately older versions of ClickHouse do not support table comment. (see https://github.com/trinodb/trino/pull/14088#discussion_r967625487)

tangjiangling avatar Sep 14 '22 10:09 tangjiangling

I assume the motivation is to cleanup some code

Correct, the diff is +19 −154. We could remove support for 21.8 too, but I feel it's too early.

ebyhr avatar Sep 14 '22 10:09 ebyhr