trino icon indicating copy to clipboard operation
trino copied to clipboard

Hide Elasticsearch prefix-based pass-through query behind feature toggle

Open kamil-rafalko opened this issue 2 years ago • 2 comments

Description

Hides Elasticsearch prefix-based pass-through query behind a feature toggle as discussed here #13390

The prefix-based pass-through query is deprecated. the raw_query table function should be used instead. To emphasize the fact that prefix-based pass-through query is deprecated before removing it at all, we decided to hide it behind the feature toggle.

Release notes

( ) This is not user-visible and no release notes are required. (x) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

kamil-rafalko avatar Sep 06 '22 17:09 kamil-rafalko

Hide Elasticsearch pass-through query behind feature toggle

We have two "pass-through queries"

  • io.trino.plugin.elasticsearch.ElasticsearchMetadata#PASSTHROUGH_QUERY_SUFFIX
  • io.trino.plugin.elasticsearch.ptf.RawQuery

please make sure the commit title indicates which one is getting behind a toggle and also add rationale to the commit message

findepi avatar Sep 12 '22 07:09 findepi

ES build is failing

findepi avatar Sep 12 '22 12:09 findepi

@kokosing @findepi @wendigo it's ready for review again. Can you take a look?

kamil-rafalko avatar Sep 26 '22 05:09 kamil-rafalko

Thank you!

kokosing avatar Sep 27 '22 20:09 kokosing

Thank you for including the docs for this change as well!

colebow avatar Sep 28 '22 18:09 colebow