trino
trino copied to clipboard
Hide Elasticsearch prefix-based pass-through query behind feature toggle
Description
Hides Elasticsearch prefix-based pass-through query behind a feature toggle as discussed here #13390
The prefix-based pass-through query is deprecated. the raw_query
table function should be used instead. To emphasize the fact that prefix-based pass-through query is deprecated before removing it at all, we decided to hide it behind the feature toggle.
Release notes
( ) This is not user-visible and no release notes are required. (x) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:
Hide Elasticsearch pass-through query behind feature toggle
We have two "pass-through queries"
-
io.trino.plugin.elasticsearch.ElasticsearchMetadata#PASSTHROUGH_QUERY_SUFFIX
-
io.trino.plugin.elasticsearch.ptf.RawQuery
please make sure the commit title indicates which one is getting behind a toggle and also add rationale to the commit message
ES build is failing
@kokosing @findepi @wendigo it's ready for review again. Can you take a look?
Thank you!
Thank you for including the docs for this change as well!