trino icon indicating copy to clipboard operation
trino copied to clipboard

Align flush_metadata_cache procedure named args with other procedures

Open aczajkowski opened this issue 3 years ago • 1 comments

Description

Follow up to @colebow PR https://github.com/trinodb/trino/pull/13398 syncing flush_metadata_cache named args with other procedures.

Related issues, pull requests, and links

  • PR https://github.com/trinodb/trino/pull/13398

Documentation

( ) No documentation is needed. (x) Sufficient documentation is included in this PR. ( ) Documentation PR is available with #prnumber. ( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required. (x) Release notes entries required with the following suggested text:

# Hive
* Align `flush_metadata_cache` named args to other procedures

aczajkowski avatar Aug 09 '22 12:08 aczajkowski

@electrum @findepi @colebow @mosabua bump

aczajkowski avatar Sep 20 '22 15:09 aczajkowski

Do we / should we have any way to warn the user in case that the parameter names used are deprecated?

findinpath avatar Sep 22 '22 14:09 findinpath

Do we / should we have any way to warn the user in case that the parameter names used are deprecated?

No haven't figured out any. We might put it in logs, but thats kinda not clear 🤷‍♂️ If there is some way it could be shown in CLI as a warning would be supper cool.

aczajkowski avatar Sep 22 '22 14:09 aczajkowski

@kokosing Done - just CI left

aczajkowski avatar Sep 27 '22 15:09 aczajkowski

@kokosing all test passed only single Product Test failed. CI Suite-2 - but looks not related at all.

aczajkowski avatar Sep 29 '22 10:09 aczajkowski

CI Suite-2 - but looks not related at all.

Please check the failure and report a flaky issue on Github. We cannot just accept flaky failures, we need to fix them eventually. Tracking them is important to understand which of those should be escalated.

kokosing avatar Sep 29 '22 10:09 kokosing

Details

@kokosing done It's added to exiting flaky test report here https://github.com/trinodb/trino/issues/6799#issuecomment-1263713925

aczajkowski avatar Sep 30 '22 15:09 aczajkowski

Thanks

kokosing avatar Sep 30 '22 19:09 kokosing